chore(bigframes): fix the missed columns when sqlglot compiles SqlDataSource#16567
Merged
chelsea-lin merged 1 commit intomainfrom Apr 6, 2026
Merged
chore(bigframes): fix the missed columns when sqlglot compiles SqlDataSource#16567chelsea-lin merged 1 commit intomainfrom
chelsea-lin merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the SQL compilation logic to support explicit column selection when reading tables, rather than defaulting to a star selection. It introduces an is_star_selection property to identify when all columns are selected and modifies the from_table method to accept a column list. Review feedback identifies inaccuracies in the from_table docstring regarding non-existent parameters and suggests a more concise implementation for constructing the SELECT expression.
packages/bigframes/bigframes/core/compile/sqlglot/sqlglot_ir.py
Outdated
Show resolved
Hide resolved
chelsea-lin
force-pushed
the
main_chelsealin_sqldatasource
branch
from
1c79704 to
1edd629
Compare
TrevorBergeron
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.